New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: k8s policies tutorial #3373
Merged
josedonizetti
merged 1 commit into
aquasecurity:main
from
josedonizetti:fix-k8s-policies-tutorial
Aug 18, 2023
Merged
fix: k8s policies tutorial #3373
josedonizetti
merged 1 commit into
aquasecurity:main
from
josedonizetti:fix-k8s-policies-tutorial
Aug 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a few comments, otherwise, looks good
josedonizetti
force-pushed
the
fix-k8s-policies-tutorial
branch
from
August 10, 2023 19:22
352622b
to
ccee566
Compare
@AnaisUrlichs hey I have addressed your question, can take another look? |
@AnaisUrlichs still waiting for your review to be able to merge this |
AnaisUrlichs
approved these changes
Aug 17, 2023
yanivagman
reviewed
Aug 17, 2023
josedonizetti
force-pushed
the
fix-k8s-policies-tutorial
branch
from
August 17, 2023 12:01
ccee566
to
f00d329
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
Fix #3368
"Replace me with
make check-pr
output"2. Explain how to test it
3. Other comments