feat: add loggers atomic level #3391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/signatures
area/testing
area/UX
area/events
area/logging
area/flags
labels
josedonizetti
force-pushed
the
add-atomic-level
branch
from
3a534c0
to
696bcaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
This PR is part of the work to support a v1 for GRPC. It adds AtomicLevel to our logger, so we can change it safely in runtime. The GRPC server will have a DiagnosticService for debugging and diagnostic tracee. One of the endpoints will be a
ChangeLogLevel.2. Explain how to test it
3. Other comments