feat: add diagnostic rpc #3395
Merged
feat: add diagnostic rpc #3395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josedonizetti
force-pushed
the
add-diagnostic-rpc
branch
from
74da521
to
3ed44ec
Compare
Merged
geyslan
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
LGTM.
I would consider just to move the types/api/v1beta1/tracee.proto fix to a proper commit like "fix(protobuf): tracee.proto go_package".
josedonizetti
force-pushed
the
add-diagnostic-rpc
branch
from
3ed44ec
to
6cf7f2f
Compare
yanivagman
reviewed
Aug 22, 2023
Comment on lines
+11
to
+12
| uint64 EventCount = 1; | ||
| uint64 EventsFiltered = 2; |
Comment on lines
+23
to
+24
| Info = 0; | ||
| Debug = 1; |
There was a problem hiding this comment.
Like discussed offline - info and debug should be switched
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
This PR is part of the work to support a v1 for GRPC. It adds a diagnostic rpc for tracee debugging, this rpc can be used to get a stacktracee live from tracee, its metrics and change log levels. This PR also fixes the version on the tracee.proto, which should have been
v1beta12. Explain how to test it
3. Other comments