Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log level should match zap log priority #3409

Merged
merged 1 commit into from Aug 23, 2023
Merged

fix: log level should match zap log priority #3409

merged 1 commit into from Aug 23, 2023

Conversation

josedonizetti
Copy link
Collaborator

@josedonizetti josedonizetti commented Aug 22, 2023 •
edited

1. Explain what the PR does

Fixex log level priority to match zap log level priority (debug has the lowest priority) https://pkg.go.dev/go.uber.org/zap@v1.25.0/zapcore#DebugLevel

2. Explain how to test it

3. Other comments

geyslan
geyslan approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@geyslan geyslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josedonizetti josedonizetti merged commit bfc4451 into aquasecurity:main Aug 23, 2023
27 checks passed
@josedonizetti josedonizetti deleted the fix-log-level branch August 23, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geyslan geyslan geyslan approved these changes

Assignees

@josedonizetti josedonizetti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@josedonizetti @geyslan