fix(definitions): ksymbols dependencies handled wrongly #3443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
rafaeldtinoco
force-pushed
the
ksymboldepsregression
branch
from
9f728f4
to
a66f642
Compare
Commit 1a47a4e attempted to fix this issue by reverting some changes made during the event definitions (and dependencies) refactor. That change caused some regressions because of another fix made together, but, since it was reverted, this commit fixes the same issue with a much simpler approach (at least until the event definitions refactor work is finished). Fixes: #3382
rafaeldtinoco
force-pushed
the
ksymboldepsregression
branch
from
ef7fbe9
to
fad5fc0
Compare
|
What brakes the E2E tests is the following change:
But the change Nadav did to the event definition ksymbols dependency isn't good IMO (and can be mitigated by a very simple change). I have merged the reversion proposed by @AlonZivony and this very minor fix (already tested in all scenarios, e2e tests, github tests and testcase from the issue #3382). Im going to leave the issue: #3383 opened to fix it in a further moment (as the behavior does not break anything and it's a "good to have" change). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit fad5fc0 (HEAD -> ksymboldepsregression, rafaeldtinoco/ksymboldepsregression)
Author: Rafael David Tinoco rafaeldtinoco@gmail.com
Date: Tue Sep 5 16:33:13 2023