feat: Add new event structure #3465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josedonizetti
force-pushed
the
add-event-proto
branch
from
84a3096
to
0f8f717
Compare
|
@yanivagman This is marked as draft but can you do a first review? There are a few questions marked with Depending on what we decide I can finish adding all possible arguments we support. |
yanivagman
requested changes
Sep 13, 2023
josedonizetti
force-pushed
the
add-event-proto
branch
from
0f8f717
to
a15d5bc
Compare
yanivagman
reviewed
Sep 18, 2023
josedonizetti
force-pushed
the
add-event-proto
branch
3 times, most recently
from
9ff4cee
to
97ea994
Compare
yanivagman
reviewed
Sep 18, 2023
josedonizetti
force-pushed
the
add-event-proto
branch
from
97ea994
to
7df532b
Compare
yanivagman
reviewed
Sep 18, 2023
josedonizetti
force-pushed
the
add-event-proto
branch
2 times, most recently
from
6359d6c
to
6d31191
Compare
roikol
reviewed
Sep 20, 2023
yanivagman
reviewed
Sep 20, 2023
josedonizetti
force-pushed
the
add-event-proto
branch
from
6d31191
to
a7978c8
Compare
josedonizetti
force-pushed
the
add-event-proto
branch
from
a7978c8
to
3d0e992
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first part of #2870. It adds the new Event structure without the event data.