fix: convert []trace.Argument into map<string,EventData>
#3510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josedonizetti
force-pushed
the
add-event-data-to-stream-events
branch
4 times, most recently
from
a599f8f
to
6e001ab
Compare
yanivagman
reviewed
Sep 27, 2023
josedonizetti
force-pushed
the
add-event-data-to-stream-events
branch
2 times, most recently
from
be28621
to
8ac236c
Compare
josedonizetti
changed the title
[]trace.Argument into map<string,EventData>
yanivagman
reviewed
Sep 28, 2023
Comment on lines
+52
to
57
| err = grpcStream.Send(&pb.StreamEventsResponse{Event: eventProto}) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
I don't think so, if we can't send is because the connection on the other side isn't there anymore for a a given reason, so we should stop sending and unsubscribe the client. WDYT?
There was a problem hiding this comment.
yes, sounds reasonable
josedonizetti
force-pushed
the
add-event-data-to-stream-events
branch
from
8ac236c
to
5b5521e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs converts
[]trace.Argumentintomap<string,EventData>, this code is temporary because later the event structure will be integrated into tracee, but I've created a test for all types to make sure we have cover all supported arguments.