Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make types uniform with wrappers #3512

Merged
merged 2 commits into from
Sep 27, 2023
Merged

fix: make types uniform with wrappers #3512

merged 2 commits into from
Sep 27, 2023

Conversation

josedonizetti
Copy link
Collaborator

1. Explain what the PR does

Changes types to be uniform with protobuf wrappers, the inside type should be named Value. Also refactor the array name IntArrayValue to have the size, like other types Int32ArrayValue.

@josedonizetti josedonizetti marked this pull request as ready for review September 27, 2023 17:51
yanivagman
yanivagman approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josedonizetti josedonizetti merged commit 44ec77c into aquasecurity:main Sep 27, 2023
26 checks passed
@josedonizetti josedonizetti deleted the fix-grpc-types branch September 27, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanivagman yanivagman yanivagman approved these changes

Assignees

@josedonizetti josedonizetti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@josedonizetti @yanivagman