fix: enrichment for kind and minikube #3598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josedonizetti
force-pushed
the
fix-enrichment
branch
from
61cbf7f
to
1414711
Compare
josedonizetti
force-pushed
the
fix-enrichment
branch
from
1414711
to
2827ca9
Compare
josedonizetti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3593
The PR #3325 introduced an optimization to avoid querying CRI on short live cgroups, this works well for all bigger gke platforms I tested (aws, azure, gke, digital ocean), but it doesn't work for minikube/kind, because the cgroup path is not accessible to a container https://github.com/aquasecurity/tracee/blob/main/pkg/containers/containers.go#L365-L374
As this is a special case for development tools only, I did a hack to not validate this whenever it is running on minikube or kind, so enrichment works.
The PR uses the downward API to know the name of the node, if the name of the node is either minikube or kind it ignores the cgroup dead valiation.