rebase of https://github.com/aquasecurity/tracee/pull/3638 #3683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add coolDown to sleep before to run the next test. - change runCmd to receive the number of expected events. - ExpectAnyOfEvts (ExpectAnyOfEach before) now call runCmd passing 1 as expected events. - eventBuffer.clear() now sets a new empty slice for it, instead of relying on the old underlying array. - replaced copyActualEvents() with eventBuffer.getCopy(). - refactored test functions, improved comments and logs.
Updated the Tracee integration tests to address a bug with the time.After usage. Previously, at each iteration of the loop, the time.After was reset whenever its corresponding select clause was reached. This behavior resulted in the creation of a new timer on each loop iteration without freeing the previous one, leading to a memory leak. The solution involved replacing time.After with a dedicated timeoutTicker, ensuring consistent timeout handling without unnecessary resource consumption.
Return all errors to the main test loop to check and abort the tracee execution in the correct way. This also: - Introduces cmdEvents.waitFor duration as a guarantee before starting to collect events after executing a command. - Changes the following tests to be certain of the events collected: . pid: trace events from pid 1 . pid: event: args: trace event sched_switch with args from pid 0 . pid: trace new (should be empty)
Closed
|
Thanks for taking care of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #3440