Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/proctree query time #3691

Merged

Conversation

AlonZivony
Copy link
Collaborator

@AlonZivony AlonZivony commented Nov 15, 2023

1. Explain what the PR does

7fa990f feat(proctree): fill timestamp of proctree info objects

Fix #3700

2. Explain how to test it

e2e test

3. Other comments

@AlonZivony
Copy link
Collaborator Author

@rafaeldtinoco WDYT?

@AlonZivony AlonZivony force-pushed the feature/proctree-query-time branch 2 times, most recently from 8071a92 to ee9d11c Compare November 20, 2023 18:21
@AlonZivony AlonZivony marked this pull request as ready for review November 21, 2023 08:25
go.mod Outdated Show resolved Hide resolved
Copy link
Contributor

@rafaeldtinoco rafaeldtinoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Needs a better reasoning and a PR changing the types before this can be merged. Im putting a -1 for now until both are satisfied. Request my review in the types change, please. I'll merge and you can rebase this and change types dependency to that commit.

@AlonZivony
Copy link
Collaborator Author

@rafaeldtinoco I probably need your opinion on the following question:
Should the query time be part of the info objects, or be part of an enveloping type to the info objects?
In my opinion it is easier to manage as part of the info object, but I am not sure that the timestamp is an info of the process in a way that justify this coupling.
We can create a generic TimeRelevantInfo type, that has information and timestamp in it, and return it instead of the process and thread info objects.
WDYT?

@rafaeldtinoco
Copy link
Contributor

We can create a generic TimeRelevantInfo type, that has information and timestamp in it, and return it instead of the process and thread info objects.

I think I prefer this idea better Alon, if you also think that.

Copy link
Contributor

@rafaeldtinoco rafaeldtinoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We agreed the location of Timestamp will be a struct called TimeRelevantInfo instead of duplicates under other Info structs.

Fill the timestamp field of proctree info objects upon query.
Copy link
Contributor

@rafaeldtinoco rafaeldtinoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaeldtinoco rafaeldtinoco merged commit 3ab4a49 into aquasecurity:main Nov 29, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Process Tree queries are missing query time
2 participants