-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/hash so #3715
Feature/hash so #3715
Conversation
@AlonZivony LGTM, I like it. YOu need to (re)generate the man pages, like the error is telling you to. After that, since all tests passed I can merge right away. There is also this test: needs checking I believe. |
9fb3713
to
370aaff
Compare
Add file hash of the shared object loaded to the event. The behavior matches the one from the sched_process_exec event.
Add file hash of the shared object loaded to the event.
370aaff
to
add3794
Compare
So it is weird, because I have ran |
@AlonZivony it's odd. 🤔 I noticed that other .1 files were changed by a lower version of pandoc but the required one. |
Well, this made the required changes: #3720 The comment in pr.yaml was misleading and the docker image was not using a pinned pandoc version; but now it's back on track. |
With this said, I believe @AlonZivony should rebase, push and then we can merge after tests succeed. |
Merged by #3721 |
1. Explain what the PR does
9fb3713 feat(events): add hash to symbols_loaded event
b1e2141 feat(events): add hash to shared_object_loaded event
Related to #3576
2. Explain how to test it
3. Other comments