chore: rename Context to EventContext #3716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaeldtinoco
approved these changes
Nov 29, 2023
geyslan
force-pushed
the
event-context-rename
branch
2 times, most recently
from
94d8fc9
to
00ffa33
Compare
|
I made a few more renames focused on avoiding confusion with context.Context. |
geyslan
force-pushed
the
event-context-rename
branch
from
00ffa33
to
f56a4ad
Compare
It aligns with the name of the type in the ebpf land, `event_context` avoiding confusion with the `context.Context` type. It also updates the respective comments.
geyslan
force-pushed
the
event-context-rename
branch
from
f56a4ad
to
4de4915
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
00ffa33 chore: rename Context to EventContext
2. Explain how to test it
3. Other comments