Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add ctime to containers data source #3728

Conversation

NDStrahilevitz
Copy link
Collaborator

1. Explain what the PR does

Add ctime of container's cgroup in data source schema and output.

2. Explain how to test it

TODO

3. Other comments

Copy link
Contributor

@rafaeldtinoco rafaeldtinoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I wouldn't merge before E2E tests are cleared.

@NDStrahilevitz
Copy link
Collaborator Author

LGTM, but I wouldn't merge before E2E tests are cleared.

Could you please +1 so I can marge once cleared? Thanks!

Copy link
Contributor

@rafaeldtinoco rafaeldtinoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaeldtinoco rafaeldtinoco merged commit a99dea0 into aquasecurity:main Dec 5, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants