Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(ebpf): avoid errors upon hash calc fail #3733

Merged

Conversation

AlonZivony
Copy link
Collaborator

1. Explain what the PR does

Avoid creating errors upon errors in hash calculations from known reasons.
This includes memfd files, and race conditions in container FS access

Fix #3732

2. Explain how to test it

3. Other comments

Avoid creating errors upon errors in hash calculations from known
reasons.
This includes memfd files, and race conditions in container FS access
Copy link
Contributor

@rafaeldtinoco rafaeldtinoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets see test results. Thanks for fixing it.

@AlonZivony
Copy link
Collaborator Author

LGTM, lets see test results. Thanks for fixing it.

The test seems to fail because of an engine happy flow test.
In my local machine all tests have passed, so it might be unrelated problem.

@rafaeldtinoco
Copy link
Contributor

so it might be unrelated problem.

Retried, lets see.

@rafaeldtinoco rafaeldtinoco merged commit 723efb7 into aquasecurity:main Dec 5, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors with new hash logic on regular systems
2 participants