Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BPF map macros #3735

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Remove BPF map macros #3735

merged 1 commit into from
Jan 17, 2024

Conversation

geyslan
Copy link
Member

@geyslan geyslan commented Dec 5, 2023 •
edited
Loading

Close #3731

1. Explain what the PR does

0e1786b chore: remove bpf map macros

Define the bpf maps manually, instead of using the macros.

Context: #3731

It also does some renaming and changes filter comments.

2. Explain how to test it

3. Other comments

@geyslan geyslan self-assigned this Dec 5, 2023
@geyslan geyslan changed the title 3731 rem bpf map macros Remove BPF map macros Dec 5, 2023
@geyslan

This comment was marked as outdated.

Sign in to view
rafaeldtinoco
rafaeldtinoco reviewed Dec 7, 2023
View reviewed changes
pkg/ebpf/c/types.h Outdated Show resolved Hide resolved
@rafaeldtinoco
Copy link
Contributor

@geyslan mind rebasing this one ?

@geyslan

This comment has been minimized.

Sign in to view
@geyslan geyslan force-pushed the 3731-rem-bpf-map-macros branch 2 times, most recently from be31cc4 to 105b9ec Compare January 15, 2024 16:38
NDStrahilevitz
NDStrahilevitz reviewed Jan 17, 2024
View reviewed changes
pkg/ebpf/c/types.h Outdated Show resolved Hide resolved
pkg/ebpf/c/tracee.bpf.c Show resolved Hide resolved
pkg/ebpf/c/types.h Outdated Show resolved Hide resolved
@geyslan
chore: remove bpf map macros
0e1786b 
Define the bpf maps manually, instead of using the macros.

Context: aquasecurity#3731

It also does some renaming and changes filter comments.
NDStrahilevitz
NDStrahilevitz approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@NDStrahilevitz NDStrahilevitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geyslan
Copy link
Member Author

geyslan commented Jan 17, 2024

@josedonizetti @rafaeldtinoco would this break your current efforts?

@geyslan
Copy link
Member Author

geyslan commented Jan 17, 2024

@josedonizetti @rafaeldtinoco would this break your current efforts?

Rebased on top of #3802 and got no conflicts.

@geyslan geyslan merged commit 7ce9956 into aquasecurity:main Jan 17, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaeldtinoco rafaeldtinoco rafaeldtinoco left review comments

@NDStrahilevitz NDStrahilevitz NDStrahilevitz approved these changes

@josedonizetti josedonizetti Awaiting requested review from josedonizetti

Assignees

@geyslan geyslan

Labels
area/ebpf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove BPF Map macros (define proper types instead)
3 participants
@geyslan @rafaeldtinoco @NDStrahilevitz