Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Add name and properties to Threat, and add Threat to Event definition. #3742

Merged
merged 4 commits into from
Dec 19, 2023
Merged

feature: Add name and properties to Threat, and add Threat to Event definition. #3742

merged 4 commits into from
Dec 19, 2023

Conversation

josedonizetti
Copy link
Collaborator

@josedonizetti josedonizetti commented Dec 6, 2023 •
edited
Loading

Fix #3741

Add name and properties to Threat, and add Threat to Event definition.

@josedonizetti josedonizetti mentioned this pull request Dec 6, 2023
Merged
@josedonizetti josedonizetti changed the title feature: add labels to event definition feature: Add name and properties to Threat, and add Threat to Event definition. Dec 18, 2023
rafaeldtinoco
rafaeldtinoco approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@rafaeldtinoco rafaeldtinoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM technically correct, feel free to merge or ask someone else for the +1 on naming and conventions if you think it is needed.

yanivagman
yanivagman approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josedonizetti josedonizetti merged commit a631c31 into aquasecurity:main Dec 19, 2023
30 checks passed
@josedonizetti josedonizetti deleted the add-labels-to-event-definition branch December 19, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaeldtinoco rafaeldtinoco rafaeldtinoco approved these changes

@yanivagman yanivagman yanivagman approved these changes

@NDStrahilevitz NDStrahilevitz NDStrahilevitz approved these changes

Assignees

@josedonizetti josedonizetti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add labels map to event definition proto
4 participants
@josedonizetti @rafaeldtinoco @yanivagman @NDStrahilevitz