Writeable datasource types #3759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure listening address is cleaned up wether gracefully or on tracee's restart.
Make sure the event pipeline starts before the ready callback is called. This is so the ready callback can reliably use tracee methods which may only work post pipeline initialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
Add types for PR #3725
Fix #3757 (opportunistically)
dfa6fe5 feature(types): add WritableDatasource interface
ef3bcd6 feat(ebpf): synchronize ready callback to pipeline
c831127 fix(grpc): cleanup listen address
2. Explain how to test it
For the bugfix: run tracee with
--grpc-listen-addrset to something (tested with both unix and tcp) close tracee and run again. Note that tracee will not fail anymore.