Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/parse finding type correctly #3760

Merged

Conversation

AlonZivony
Copy link
Collaborator

1. Explain what the PR does

Fix #3758

2. Explain how to test it

3. Other comments

Fix all type whose names were given incorrectly.
Add missing types supported by the Unmarshall function to supported finding args types.
Some basic argument types names weren't supported by the Unmarshal function.
This will help signatures and events writers to avoid runtime errors.
Copy link
Contributor

@rafaeldtinoco rafaeldtinoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaeldtinoco rafaeldtinoco merged commit e863882 into aquasecurity:main Dec 13, 2023
31 checks passed
@AlonZivony AlonZivony deleted the bugfix/parse-finding-type-correctly branch December 14, 2023 11:03
@AlonZivony AlonZivony restored the bugfix/parse-finding-type-correctly branch June 13, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finding argument type creating does not match its parsing
2 participants