Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create pid file under install-path #3775

Merged

Conversation

NDStrahilevitz
Copy link
Collaborator

1. Explain what the PR does

5ca4667 fix: create pid file under install-path

Fix #3756

2. Explain how to test it

Run tracee --install-path /tmp/blah/hehe
Confirm with ls /tmp/blah/hehe/tracee.pid that tracee.pid will be under that path.

Copy link
Collaborator

@josedonizetti josedonizetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But there are some tests broken, random failure or related to the change?

@NDStrahilevitz
Copy link
Collaborator Author

Looks good! But there are some tests broken, random failure or related to the change?

Probably related, need to investigate.

@NDStrahilevitz NDStrahilevitz marked this pull request as draft December 20, 2023 12:17
@NDStrahilevitz NDStrahilevitz marked this pull request as ready for review December 20, 2023 19:48
@NDStrahilevitz NDStrahilevitz merged commit 0ed9d73 into aquasecurity:main Dec 21, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creation of tracee.pid file is not under installation path and not configurable
2 participants