Pin revive version #3796
Merged
Pin revive version #3796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geyslan
force-pushed
the
3795-pin-revive-version
branch
from
e0b4674
to
77163fa
Compare
revive v1.3.5 wrongly includes a replace directive which breaks the go install command. This commit pins revive to e33fb87 that is the fix for this issue.
geyslan
force-pushed
the
3795-pin-revive-version
branch
from
77163fa
to
27f176a
Compare
- Removes go.mod replace directive for github.com/kubernetes/cri-api. - Bump it to v0.29.0. More info: https://kubernetes.io/blog/2022/12/09/kubernetes-v1-26-release/#cri-v1alpha2-removed
geyslan
force-pushed
the
3795-pin-revive-version
branch
from
27f176a
to
186bded
Compare
Thanks @rafaeldtinoco. I've made changes addressing @NDStrahilevitz concerns. LMK if it's ok. |
NDStrahilevitz
approved these changes
Jan 5, 2024
|
Commit 186bded has been reported to break some local environments. This is due to the local use of golang version from 1.21. To avoid this, use the same version (1.20.8) of the github workflow (tests) locally: https://github.com/aquasecurity/tracee/blob/main/.github/actions/build-dependencies/action.yaml#L18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #3795
1. Explain what the PR does
186bded chore: bump k8s.io/cri-api
c51481b fix: pin revive to e33fb87
2. Explain how to test it
3. Other comments