fix(ebpf): fix hidden_kernel_module error in some kernels #3797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlonZivony
reviewed
Jan 7, 2024
On some kernels, while iterating module_kset, we need to check if we've encountered the first module we iterated on, marking we iterated over all modules instead of continuing iterating indefinitely.
OriGlassman
force-pushed
the
fix_hid_mod
branch
from
999c5a7
to
d46b5fe
Compare
|
Is this solving the recently reported issue (from an user) where IR code wasn't unrolling this loop more than 60 times (other than the 600 default) ? @AlonZivony @OriGlassman |
Not aware of such issue, can you provide a link? |
https://aquasecurity.slack.com/archives/C03MEDREVL7/p1703659096759989 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some kernels, while iterating module_kset, we need to check if we've encountered the first module we iterated on, marking we iterated over all modules instead of continuing iterating indefinitely (max amount of iterations - causing a BPF_LOG_ID_UNSPEC error message)
1. Explain what the PR does
On some kernels, while iterating module_kset, we need to check if we've encountered the first module we iterated on, marking we iterated over all modules instead of continuing iterating indefinitely.
2. Explain how to test it
/tracee -e=hidden_kernel_module
3. Other comments