Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(capture): restore absolute time in pcap frames #3800

Merged

Conversation

AlonZivony
Copy link
Collaborator

1. Explain what the PR does

1763cd4 fix(capture): restore absolute time in pcap frames

Use the normal process events step in the pipeline for the network capture buffer pipeline as well.
This fixes the issue that the conversion of the monotonic time to absolute time moved from the decode step to the process step, leaving the network capture events timestamp monotonic.

Fix #3799

2. Explain how to test it

3. Other comments

@AlonZivony
Copy link
Collaborator Author

@rafaeldtinoco I didn't do it in this PR, but I would have preferred to just put the network capture event processor in the normal processEvent step.
This will require to create priorities for the registration, so processor functions could be called before or after the timestamp change to absolute time.
Anyways it seems to me like a change that should be in its dedicated PR, so not relevant to here.

@AlonZivony AlonZivony force-pushed the bugfix/absolute-pcap-timestamps branch from 1763cd4 to 9c5f416 Compare January 18, 2024 11:31
Copy link
Collaborator

@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Use the normal process events step in the pipeline for
the network capture buffer pipeline as well.
This fixes the issue that the conversion of the monotonic
time to absolute time moved from the decode step to the process
step, leaving the network capture events timestamp monotonic.
@AlonZivony AlonZivony force-pushed the bugfix/absolute-pcap-timestamps branch from 9c5f416 to 199ed8b Compare January 21, 2024 14:41
Copy link
Collaborator

@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aqua-ci
Copy link

aqua-ci commented Jan 22, 2024

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-03f75150a60f7edf7_3800-7602236235_01' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

@aqua-ci
Copy link

aqua-ci commented Jan 22, 2024

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-028acebc5083c4840_3800-7602236235_01' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

@yanivagman yanivagman merged commit 17b2d64 into aquasecurity:main Jan 22, 2024
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pcap packets timestamp is relative
3 participants