-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(capture): restore absolute time in pcap frames #3800
fix(capture): restore absolute time in pcap frames #3800
Conversation
@rafaeldtinoco I didn't do it in this PR, but I would have preferred to just put the network capture event processor in the normal |
1763cd4
to
9c5f416
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Use the normal process events step in the pipeline for the network capture buffer pipeline as well. This fixes the issue that the conversion of the monotonic time to absolute time moved from the decode step to the process step, leaving the network capture events timestamp monotonic.
9c5f416
to
199ed8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[ERROR] |
[ERROR] |
1. Explain what the PR does
1763cd4 fix(capture): restore absolute time in pcap frames
Use the normal process events step in the pipeline for the network capture buffer pipeline as well.
This fixes the issue that the conversion of the monotonic time to absolute time moved from the decode step to the process step, leaving the network capture events timestamp monotonic.
Fix #3799
2. Explain how to test it
3. Other comments