-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make policies config versioned #3809
Conversation
ce15719
to
c9bd65e
Compare
Gonna document it on NBD. |
5dd0df0
to
96b599f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This extracts the policy-related fields from config_entry_t into a new, separate struct (policies_config_t), which continues to be stored in the config_entry_t struct, as well as in the versioned policies_config_map. This is required to enable access to the appropriate policies_config_t based on the policy version.
96b599f
to
172f533
Compare
[ERROR] |
2 similar comments
[ERROR] |
[ERROR] |
Close: #3805
Part of #3239.
1. Explain what the PR does
172f533 chore: make policies config versioned
2. Explain how to test it
3. Other comments