Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make policies config versioned #3809

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

geyslan
Copy link
Member

@geyslan geyslan commented Jan 17, 2024

Close: #3805

Part of #3239.

1. Explain what the PR does

172f533 chore: make policies config versioned

This extracts the policy-related fields from config_entry_t into a new,
separate struct (policies_config_t), which continues to be stored in the
config_entry_t struct, as well as in the versioned policies_config_map.

This is required to enable access to the appropriate policies_config_t
based on the policy version.

2. Explain how to test it

3. Other comments

@geyslan geyslan self-assigned this Jan 17, 2024
@geyslan geyslan force-pushed the 3805-pol-cfg-version branch 3 times, most recently from ce15719 to c9bd65e Compare January 17, 2024 22:50
@geyslan
Copy link
Member Author

geyslan commented Jan 17, 2024

Gonna document it on NBD.

@geyslan geyslan force-pushed the 3805-pol-cfg-version branch 2 times, most recently from 5dd0df0 to 96b599f Compare January 18, 2024 20:51
@geyslan geyslan marked this pull request as ready for review January 18, 2024 20:51
Copy link
Collaborator

@NDStrahilevitz NDStrahilevitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/ebpf/c/common/filtering.h Show resolved Hide resolved
Copy link
Collaborator

@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pkg/policy/ebpf.go Outdated Show resolved Hide resolved
This extracts the policy-related fields from config_entry_t into a new,
separate struct (policies_config_t), which continues to be stored in the
config_entry_t struct, as well as in the versioned policies_config_map.

This is required to enable access to the appropriate policies_config_t
based on the policy version.
@aqua-ci
Copy link

aqua-ci commented Jan 22, 2024

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-0c0d64eea6367efd8_3809-7611232561_01' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

2 similar comments
@aqua-ci
Copy link

aqua-ci commented Jan 22, 2024

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-0c0d64eea6367efd8_3809-7611232561_01' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

@aqua-ci
Copy link

aqua-ci commented Jan 22, 2024

[ERROR]
GitHub self-host runner 'github-self-hosted_ami-0c0d64eea6367efd8_3809-7611232561_01' failed with connecting to GitHub.
Please cancel workflow and wait until infrastructure team investigation.

@geyslan geyslan merged commit f23114d into aquasecurity:main Jan 22, 2024
31 of 32 checks passed
@aquasecurity aquasecurity deleted a comment from aqua-ci Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config policies field need versioning
4 participants