Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove clang march flag #3831

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

geyslan
Copy link
Member

@geyslan geyslan commented Jan 30, 2024

1. Explain what the PR does

f771010 chore: remove clang march flag

clang versions ~16 and above do not support the march flag.

- 16.0.6:

  clang: warning: argument unused during compilation: '-march=bpf' [-Wunused-command-line-argument]

- 17.0.2:

  clang: error: unsupported option '-march=' for target 'bpf'

2. Explain how to test it

3. Other comments

clang versions ~16 and above do not support the march flag.

- 16.0.6:

  clang: warning: argument unused during compilation: '-march=bpf' [-Wunused-command-line-argument]

- 17.0.2:

  clang: error: unsupported option '-march=' for target 'bpf'
Copy link
Collaborator

@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geyslan geyslan merged commit e3c4b82 into aquasecurity:main Jan 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants