fix: skip timestamp normalizing in derived events #3835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josedonizetti
approved these changes
Jan 31, 2024
| @@ -331,6 +331,12 @@ func (t *Tracee) processPrintMemDump(event *trace.Event) error { | |||
| // normalizeEventCtxTimes normalizes the event context timings to be relative to tracee start time | |||
| // or current time in nanoseconds. | |||
| func (t *Tracee) normalizeEventCtxTimes(event *trace.Event) error { | |||
| eventId := events.ID(event.EventID) | |||
| if eventId > events.MaxCommonID && eventId < events.MaxUserSpace { | |||
There was a problem hiding this comment.
nitpick: can we extract for this with better naming? events.IsDerivedEvent()
wdyt?
There was a problem hiding this comment.
nitpick: can we extract for this with better naming?
events.IsDerivedEvent()
wdyt?
LGTM as well. The method suggested is a good idea.
There was a problem hiding this comment.
I think that when we do extensions, we will need specified "sections" per event type. Then we can easily classify by section location. I assume that that change will break this one, so we don't necessarily need this right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
a78e7c1: fix: skip timestamp normalizing in derived events
2. Explain how to test it
tracee --events container_createdocker run --rm ubuntu3. Other comments
Fix #3828