Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change missing probe log level #3836

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

josedonizetti
Copy link
Collaborator

It should be a warn when an event can't be load becaues of a missing probe.

Copy link
Member

@geyslan geyslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@NDStrahilevitz NDStrahilevitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add in the log the reason the probe is missing (the error message of the failed attachment)?

Copy link
Collaborator

@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josedonizetti
Copy link
Collaborator Author

@NDStrahilevitz error added!

@josedonizetti josedonizetti merged commit ccb2c11 into aquasecurity:main Feb 1, 2024
32 checks passed
@josedonizetti josedonizetti deleted the change-log-level branch February 1, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants