fix(processors): change args values by name #3838
Conversation
AlonZivony
force-pushed
the
bugfix/mem-dump-args-order
branch
from
abfb8be
to
d158d04
Compare
|
@AlonZivony even not reproducing the issue I was doing changes similar to yours. That's great. Could you just add another fix to it? Please, see procTreeForkRemoveArgs(). It's not updating ArgNum. |
|
@AlonZivony Thanks! Not doing it through a set is a current problem of migrating to the new event structure, kind of doing something similar there! :D |
Already done that fix in #3839 |
|
LGTM |
Change all places that change args values in processors to find arguments by their names instead of index. This way the order of the arguments received from the kernel shall not cause bugs. Co-authored-by: Geyslan Gregório <geyslan@gmail.com>
AlonZivony
force-pushed
the
bugfix/mem-dump-args-order
branch
from
d158d04
to
8ae8b0f
Compare
Please don't merge before getting this into AlonZivony#4 |
|
@geyslan I added it as part of this PR. |
|
@AlonZivony Can this be merged for the release? |
1. Explain what the PR does
Change all places that change args values in processors to find arguments by their names instead of index.
This way the order of the arguments received from the kernel shall not cause bugs.
2. Explain how to test it
3. Other comments