Set exec-hash default option #3852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exechash can be set again as 'option:exec-hash' which will set it now as 'dev-inode' as default.
|
I didn't tackled this first option since it would demand to propagate information of the flag chosen through the parsing. But can be tackled via other issue. |
AlonZivony
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
LGTM.
However, this does not address what @NDStrahilevitz offered - when the containers enrichment is active using the digest-inode option is preferable.
IMO, this is good enough, as the enrichment is not necessarily stable for all events.
However, this will probably result users never use the digest option, even though it is better overall except if enrichment is not stable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #3817
1. Explain what the PR does
354c152 fix: typo
e481dbb fix(flags): rollback exechash cli api
e481dbb fix(flags): rollback exechash cli api
2. Explain how to test it
3. Other comments