Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhook message formatting using go templates #582

Merged
merged 13 commits into from
Mar 4, 2021
Merged

Webhook message formatting using go templates #582

merged 13 commits into from
Mar 4, 2021

Conversation

simar7
Copy link
Member

@simar7 simar7 commented Feb 27, 2021 •
edited

This PR aims to add the following:

  • Formatting webhook payloads with supplied templates
  • Using a user supplied template for formatting payload
  • Additional refactoring & testing

Fixes: #539

Sample usage:

tracee-rules --input-tracee format:json --webhook="http://foo.local" --webhook-template="templates/simple.tmpl" --content-type="application/json"

Signed-off-by: Simarpreet Singh simar@linux.com

@simar7 simar7 self-assigned this Feb 27, 2021
itaysk
itaysk requested changes Feb 28, 2021
View reviewed changes
tracee-rules/output.go Outdated Show resolved Hide resolved
tracee-rules/output.go Show resolved Hide resolved
tracee-rules/output.go Outdated Show resolved Hide resolved
tracee-rules/output.go Outdated Show resolved Hide resolved
tracee-rules/output_test.go Outdated Show resolved Hide resolved
simar7 added 11 commits March 2, 2021 14:07
@simar7
feat: Refactor sendToWebhook().
d98d7c1 
Signed-off-by: Simarpreet Singh <simar@linux.com>
@simar7
feat: Add a simple barebones template.
31a3cd9 
Signed-off-by: Simarpreet Singh <simar@linux.com>
@simar7
feat: Add some sad paths for template output
38c7664 
Signed-off-by: Simarpreet Singh <simar@linux.com>
@simar7
feat: Add CSV template for webhook output
3b637af 
Signed-off-by: Simarpreet Singh <simar@linux.com>
@simar7
feat: Add XML template for webhooks
7485f5e 
Signed-off-by: Simarpreet Singh <simar@linux.com>
@simar7
feat: Update readme.md for webhook-template
cd11481 
Signed-off-by: Simarpreet Singh <simar@linux.com>
@simar7
fix: Format in UTC time
91eb133 
Signed-off-by: Simarpreet Singh <simar@linux.com>
@simar7
feat: Initialize template once and pass around
8fb3451 
Signed-off-by: Simarpreet Singh <simar@linux.com>
@simar7
feat: Update readme to include template usage
7b861fb 
Signed-off-by: Simarpreet Singh <simar@linux.com>
@simar7
feat: Add --content-type flag
df1b689 
Signed-off-by: Simarpreet Singh <simar@linux.com>
@simar7
feat: Use current time for template payloads
6afa098 
Signed-off-by: Simarpreet Singh <simar@linux.com>
itaysk
itaysk requested changes Mar 3, 2021
View reviewed changes
tracee-rules/output.go Outdated Show resolved Hide resolved
tracee-rules/main.go Outdated Show resolved Hide resolved
tracee-rules/output.go Show resolved Hide resolved
@simar7
fix: Log but don't error if content-type is not set
35fa90d 
Signed-off-by: Simarpreet Singh <simar@linux.com>
@simar7
feat: Update Readme to reflect new flag usage
ee67873 
Signed-off-by: Simarpreet Singh <simar@linux.com>
@itaysk itaysk mentioned this pull request Mar 4, 2021
Closed
@simar7 simar7 merged commit 9c6d248 into aquasecurity:main Mar 4, 2021
This was referenced Mar 13, 2021
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantseltzer grantseltzer grantseltzer left review comments

@itaysk itaysk itaysk approved these changes

Assignees

@simar7 simar7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use gotemplate to format webhook message
3 participants
@simar7 @itaysk @grantseltzer