feat: Bump up to go1.16 #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation for #434 Signed-off-by: Simarpreet Singh <simar@linux.com>
simar7
commented
Mar 3, 2021
Comment on lines
15
to
+18
| - name: Setup Go | ||
| uses: actions/setup-go@v1 | ||
| with: | ||
| go-version: 1.15 | ||
| go-version: 1.16 |
There was a problem hiding this comment.
I wonder if we should just eliminate this setup since Ubuntu 20.04 Github Actions runner includes this by default anyway: https://github.com/actions/virtual-environments/blob/ubuntu20/20210219.1/images/linux/Ubuntu2004-README.md#go
We actually current don't have it for tracee-ebpf action: https://github.com/aquasecurity/tracee/blob/main/.github/workflows/pr-ebpf.yaml#L17-L25
There was a problem hiding this comment.
we don't have it in tracee-ebpf because it runs in a container.
personally I think it's better to be specific which version we are using to avoid future bugs
itaysk
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for #434
Signed-off-by: Simarpreet Singh simar@linux.com