Cleanup ringbuffer stop logic #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up the design of a solution to an issue where Stop() could be called after the sole consumer of the rb.stop channel has closed but rb.stopped has not yet been set. This removes the need to have a non-blocking channel write with `select` as it turns out we really don't need this channel at all. Signed-off-by: grantseltzer <grantseltzer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: rb.stopped should be set in the Stop method
This cleans up the design of a solution to an issue where Stop()
could be called after the sole consumer of the rb.stop channel
has closed but rb.stopped has not yet been set. This removes
the need to have a non-blocking channel write with
selectasit turns out we really don't need this channel at all.
Signed-off-by: grantseltzer grantseltzer@gmail.com