feat: Add signature versioning #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #530 Signed-off-by: Simarpreet Singh <simar@linux.com>
itaysk
reviewed
Mar 6, 2021
There was a problem hiding this comment.
could you update the examples too? and also print it in the --list option.
This will probably affect how we reference rules, which is now by ID, and will have to include the version at some point. I guess we can postpone this work until we have a better idea on rule distribution
Signed-off-by: Simarpreet Singh <simar@linux.com>
This is a new feature. I will create a PR to take care of it shortly. Here: #602 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #530
Signed-off-by: Simarpreet Singh simar@linux.com