-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move and document the signature helpers #601
Conversation
Signed-off-by: grantseltzer <grantseltzer@gmail.com>
Signed-off-by: grantseltzer <grantseltzer@gmail.com>
Signed-off-by: grantseltzer <grantseltzer@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think the rego helpers should move to a dedicated package (like you already did before) (just the name, not the directory). in rego conventions that would be like package tracee.helpers
also, probably worth adding code comments to document the helper functions themselves. but this can be a separate PR if you'd like |
How is this different from how it is now?
On it |
my bad :) got confused for a moment |
This moves both the rego and go helper functions into their own package, updates usage and Makefile accordingly. (#599)
It also adds notes in the README about them (#538).
Signed-off-by: grantseltzer grantseltzer@gmail.com