Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move and document the signature helpers #601

Merged
merged 3 commits into from
Mar 17, 2021
Merged

fix: move and document the signature helpers #601

merged 3 commits into from
Mar 17, 2021

Conversation

grantseltzer
Copy link
Contributor

This moves both the rego and go helper functions into their own package, updates usage and Makefile accordingly. (#599)

It also adds notes in the README about them (#538).

Signed-off-by: grantseltzer grantseltzer@gmail.com

Signed-off-by: grantseltzer <grantseltzer@gmail.com>
Signed-off-by: grantseltzer <grantseltzer@gmail.com>
Signed-off-by: grantseltzer <grantseltzer@gmail.com>
Copy link
Collaborator

@itaysk itaysk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think the rego helpers should move to a dedicated package (like you already did before) (just the name, not the directory). in rego conventions that would be like package tracee.helpers

@itaysk
Copy link
Collaborator

itaysk commented Mar 12, 2021

also, probably worth adding code comments to document the helper functions themselves. but this can be a separate PR if you'd like

@grantseltzer
Copy link
Contributor Author

I do think the rego helpers should move to a dedicated package (like you already did before) (just the name, not the directory). in rego conventions that would be like package tracee.helpers

How is this different from how it is now?

also, probably worth adding code comments to document the helper functions themselves. but this can be a separate PR if you'd like

On it

@itaysk
Copy link
Collaborator

itaysk commented Mar 13, 2021

How is this different from how it is now?

my bad :) got confused for a moment

@itaysk itaysk merged commit 9753401 into aquasecurity:main Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move go helpers to tracee-rules document signature helpers
3 participants