Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding labels to Docker image #625

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Conversation

krol3
Copy link
Contributor

@krol3 krol3 commented Mar 16, 2021

Related #391
Adding labels to Docker image

Copy link
Contributor

@grantseltzer grantseltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

Would there be a reason to add these ARG/LABELs to the dockerfiles in tracee-ebpf and tracee-rules ? Not that familiar with the relationship between them.

@krol3
Copy link
Contributor Author

krol3 commented Mar 18, 2021

This ARG/LABEL will create the labels in the image. For example
docker inspect tracee:latest


            "OnBuild": null,
            "Labels": {
                "org.label-schema.build-date": "2021-03-18T01:22:33Z",
                "org.label-schema.description": "Linux Runtime Security and Forensics using eBPF",
                "org.label-schema.name": "tracee",
                "org.label-schema.schema-version": "1.0",
                "org.label-schema.vcs-branch": "labels-docker",
                "org.label-schema.vcs-ref": "7492580",
                "org.label-schema.vcs-url": "https://github.com/aquasecurity/tracee",
                "org.label-schema.vendor": "Aqua Security",
                "org.label-schema.version": "test"
            }
        },
        "Architecture": "amd64",

@grantseltzer
Copy link
Contributor

Ah got it, thanks for the clarification! Would the labels be appropriate for this dockerfile as well?

@krol3
Copy link
Contributor Author

krol3 commented Mar 19, 2021

I follow the labels created already by the golang release. For example. these are the trivy labels

LABEL org.label-schema.build-date=2021-02-08T10:20:47Z
LABEL org.label-schema.description=A Fast Vulnerability
LABEL org.label-schema.name=trivy
LABEL org.label-schema.schema-version=1.0
LABEL org.label-schema.vcs=https://github.com/aquasecurity/trivy
LABEL org.label-schema.vcs-ref=cdabe7fc9e74000911269228ebe3cb59f3879df4
LABEL org.label-schema.vendor=Aqua Security
LABEL org.label-schema.version=0.16.0

@grantseltzer grantseltzer merged commit f8df7da into aquasecurity:main Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants