Use Go templates for stdout #630
Conversation
Signed-off-by: Simarpreet Singh <simar@linux.com>
Signed-off-by: Simarpreet Singh <simar@linux.com>
Signed-off-by: Simarpreet Singh <simar@linux.com>
Signed-off-by: Simarpreet Singh <simar@linux.com>
Signed-off-by: Simarpreet Singh <simar@linux.com>
Signed-off-by: Simarpreet Singh <simar@linux.com>
Signed-off-by: Simarpreet Singh <simar@linux.com>
Signed-off-by: Simarpreet Singh <simar@linux.com>
| type FindingWithMetadata struct { | ||
| Finding | ||
| SignatureMetadata | ||
| } |
There was a problem hiding this comment.
@simar7 what do you think on changing Finding type to include the SignatureMetadata instead of the Signature interface? @yanivagman also curios what you think
There was a problem hiding this comment.
Signature interface has GetMetadata() method - why not using it when needed?
There was a problem hiding this comment.
Yaniv and I discussed this offline, we should replace signature field with signaturemetadata in the finding. This will simplify many cases without sacrificing much.
There was a problem hiding this comment.
Should we do that as part of this PR? I'm happy to do it just feel it's unrelated to this PR as modifying an existing interface requires all users of it (example signatures in this case) to be changed as well.
Signed-off-by: Simarpreet Singh <simar@linux.com>
Signed-off-by: Simarpreet Singh <simar@linux.com>
tracee-rules/output.go
Outdated
| @@ -37,6 +38,7 @@ func setupTemplate(inputTemplateFile string, clock Clock) (*template.Template, e | |||
| case inputTemplateFile != "": | |||
| return template.New(filepath.Base(inputTemplateFile)). | |||
| Funcs(funcMap). | |||
There was a problem hiding this comment.
NB: I'm still keeping this in because to my knowledge there's no way to inject a custom time interface into sprig which makes it untestable for our most common case of template (simple and verbose) where we need the current time.
There was a problem hiding this comment.
why do we need to test it specifically? if we want to test that the templating engine works, can we craft a simpler template for the test?
There was a problem hiding this comment.
Yes fair point. I wanted to test the default output (without any templates, which includes a timestamp). I found a another way to do it bf6a78f and cleaned this up.
Signed-off-by: Simarpreet Singh <simar@linux.com>
This PR adds the following:
--outputflag to tracee-rules, which enables to BYOT (bring your own template) for stdout.--output, tracee-rules uses a default predefined template.Fixes: #612, #611 and #614
Signed-off-by: Simarpreet Singh simar@linux.com