Use libbpfgo/helpers package in tracee-ebpf #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elper package Signed-off-by: grantseltzer <grantseltzer@gmail.com>
helpers package Signed-off-by: grantseltzer <grantseltzer@gmail.com>
I don't think we should copy these helpers. The string representation of an address can be considered as "raw" by itself |
yanivagman
approved these changes
Mar 18, 2021
|
@yanivagman I think 1600 lines is enough for tracee.go, to be honest I wouldn't mind breaking it up further to make it easier to read/navigate. Lets handle that in a future discussion/PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #493, which should fully close out #485
Question I have is whether or not we want to copy over the
PrintUint32IPandPrint16BytesSliceIPto this helpers package. Not sure if it's relevant enough?