Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add high level overview to Readme #650

Merged
merged 3 commits into from
Mar 29, 2021
Merged

feat: Add high level overview to Readme #650

merged 3 commits into from
Mar 29, 2021

Conversation

simar7
Copy link
Member

@simar7 simar7 commented Mar 26, 2021

Fixes: #637

Signed-off-by: Simarpreet Singh simar@linux.com

@simar7 simar7 self-assigned this Mar 26, 2021
Readme.md Outdated
@@ -17,6 +17,7 @@ Tracee is composed of the following sub-projects:
- [libbpgo](libbpfgo) - Go library for eBPF programming using Linux's [libbpf](https://github.com/libbpf/libbpf)

## Getting started
![High Level Overview](images/highleveloverview.png)
Copy link
Collaborator

@itaysk itaysk Mar 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't put this under getting started as it doesn't help the user get started. IMO the end user shouldn't even be aware of the intricacies of the internal components, only developers should. In the new readme (#647 ) this would fit under the "components" section. Appreciate if you could rebase on that PR (once merged)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, perhaps it would be beneficial to have an architecture.md file, for the sake of introducing contributors to tracee (as opposed to users which have the docs site). at first this doc can just contain this diagram, perhaps in the future we will add content

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sure I'm OK with that. I can change it live in architecture.md instead.

@grantseltzer
Copy link
Contributor

I need to try excalidraw, diagram looks great! My only comment is the "event detected" by (3). If I understand correctly all of the events are fed to tracee-rules in which case I feel 'event detected' makes more sense to be inside of tracee-rules's box.

Perhaps a better thing to put there is "flow of events created by tracee-ebpf"? And the 'events sent' from (2) should be "events created"?

@simar7
Copy link
Member Author

simar7 commented Mar 26, 2021

I need to try excalidraw, diagram looks great! My only comment is the "event detected" by (3). If I understand correctly all of the events are fed to tracee-rules in which case I feel 'event detected' makes more sense to be inside of tracee-rules's box.

Perhaps a better thing to put there is "flow of events created by tracee-ebpf"? And the 'events sent' from (2) should be "events created"?

Right, how about I change it to:
(3) events collected
(4) report findings

Signed-off-by: Simarpreet Singh <simar@linux.com>
Signed-off-by: Simarpreet Singh <simar@linux.com>
Copy link
Collaborator

@itaysk itaysk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title over the tracee-rules block should say detection, imo. Otherwise lgtm

Signed-off-by: Simarpreet Singh <simar@linux.com>
@simar7 simar7 merged commit e868978 into aquasecurity:main Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create architecture diagram of the interaction between tracee-ebpf and tracee-rules
3 participants