Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove falcosidekick specific code and reuse templating #653

Merged
merged 2 commits into from
Mar 29, 2021
Merged

refactor: Remove falcosidekick specific code and reuse templating #653

merged 2 commits into from
Mar 29, 2021

Conversation

simar7
Copy link
Member

@simar7 simar7 commented Mar 26, 2021

This PR removes Falcosidekick specific code and reuses the templating logic to build the same.

Fixes #627

Signed-off-by: Simarpreet Singh simar@linux.com

Signed-off-by: Simarpreet Singh <simar@linux.com>
@simar7 simar7 self-assigned this Mar 26, 2021
@itaysk
Copy link
Collaborator

itaysk commented Mar 29, 2021

LGTM but I'm trying to understand why tests failed.
In the previous PR to this area the same tests failed but GH didn't show the workflow as failed https://github.com/aquasecurity/tracee/pull/646/checks#step:7:148
I think it's ok to merge this PR (just because the previous one failed as well), and immediately investigate the failure

Signed-off-by: Simarpreet Singh <simar@linux.com>
@simar7
Copy link
Member Author

simar7 commented Mar 29, 2021

LGTM but I'm trying to understand why tests failed.
In the previous PR to this area the same tests failed but GH didn't show the workflow as failed https://github.com/aquasecurity/tracee/pull/646/checks#step:7:148
I think it's ok to merge this PR (just because the previous one failed as well), and immediately investigate the failure

Actually tests only failed in this PR (which is an oversight on my part to not run all of them prior to pushing). The run you have linked has all tests passing. The red warnings you see in that run are coming from rego based tests and are not actual errors. GitHub UI just shows them like that. We could probably do something to clear that noise.

@simar7 simar7 merged commit 50a6940 into aquasecurity:main Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove the falcosidekick struct from the webhook code
2 participants