-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes for documentation #657
Conversation
Signed-off-by: grantseltzer <grantseltzer@gmail.com>
… usage accordingly Signed-off-by: grantseltzer <grantseltzer@gmail.com>
Signed-off-by: grantseltzer <grantseltzer@gmail.com>
Signed-off-by: grantseltzer <grantseltzer@gmail.com>
logo: images/tracee.png | ||
logo: images/tracee_logo_only.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Seems like we have two asset sources now, one under docs/images/
and one under images/
could we reconcile them somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR removes the images/
directory for the base of the repo completely. This particular line is referencing the one in docs/images/
Signed-off-by: grantseltzer <grantseltzer@gmail.com>
238dec9
to
1092871
Compare
@@ -1,19 +1,19 @@ | |||
# Prerequisites | |||
|
|||
- Linux kernel version >= 4.18 | |||
- Linux kernel headers available under conventional location (see [Linux Headers](#TODO) section for more info) | |||
- libc, and the libraries: libelf, zlib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libbpf is not a prerequisite (the the user)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@itaysk are you saying that because we package libbpf source code with this repo?
Would all these library prerequisites be eliminated if we statically compile our releases? And headers once I finish with CO:RE?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if someone wants to run tracee, they can download the binary, and run it, they don't need to have libbpf in order for tracee to run, right? the same can't be said for libelf, zlib which are required at runtime.
Yes I think if we statically compile tracee those reqs would be eliminated
This handles #652