Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a dockerignore #682

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Adding a dockerignore #682

merged 1 commit into from
Apr 7, 2021

Conversation

krol3
Copy link
Contributor

@krol3 krol3 commented Apr 6, 2021

Related the issue #681

itaysk
itaysk approved these changes Apr 6, 2021
View reviewed changes
Copy link
Collaborator

@itaysk itaysk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's sounds like a good solution to me! let's get another reviewer though, just to make sure I'm not missing anything (haven't run it)

@krol3
Copy link
Contributor Author

krol3 commented Apr 6, 2021

Of course! I tested it using the same steps about the open issue. But maybe another collateral effect in the other dockerfiles could happen.

@grantseltzer
Copy link
Contributor

So this would mean when we run COPY . /tracee here it wouldn't copy in the dist directories, right?

@grantseltzer grantseltzer merged commit 7b3c71b into aquasecurity:main Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itaysk itaysk itaysk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@krol3 @grantseltzer @itaysk