Add check for empty bytes being written by file write channel #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leWrChannel Signed-off-by: grantseltzer <grantseltzer@gmail.com>
itaysk
approved these changes
Apr 13, 2021
|
No I don't believe so, this is specifically related to the file write channel. |
|
Note that this doesn't fix the root cause of the bug. |
This was referenced Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to handle #690
The "EOF" error is printed as a result of the File Write Channel sending empty raw data. I believe the reason for this has to do with allocating memory for []byte{} that'd be send over the file_write channel, but nothing ever being written, leading it to being drained in this way.
This will skip over empty raw data that's been sent. Alternatively we can add a check for
err == io.EOFand ignore it specifically.Signed-off-by: grantseltzer grantseltzer@gmail.com