Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracee-ebpf: fix incomplete path #812

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

yanivagman
Copy link
Collaborator

@yanivagman yanivagman commented Jul 10, 2021

fix #811

Bug introduced in #758

@@ -1307,7 +1307,7 @@ static __always_inline int save_path_to_str_buf(buf_t *string_p, const struct pa
bpf_probe_read(&dentry, sizeof(struct dentry*), &mnt_p->mnt_mountpoint);
bpf_probe_read(&mnt_p, sizeof(struct mount*), &mnt_p->mnt_parent);
bpf_probe_read(&mnt_parent_p, sizeof(struct mount*), &mnt_p->mnt_parent);
bpf_probe_read(&vfsmnt, sizeof(struct vfsmount*), (const void*)&mnt_p->mnt);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem here is that mnt_p->mnt is of type struct vfsmount and not struct vfsmount*

Copy link
Contributor

@grantseltzer grantseltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@grantseltzer grantseltzer merged commit b3b7346 into aquasecurity:main Jul 12, 2021
@yanivagman yanivagman deleted the fix_save_path branch March 7, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

saved path might be incomplete
2 participants