Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add flag for prepared events #984

Merged
merged 6 commits into from
Sep 7, 2021
Merged

feat: Add flag for prepared events #984

merged 6 commits into from
Sep 7, 2021

Conversation

simar7
Copy link
Member

@simar7 simar7 commented Sep 2, 2021 •
edited

Adds a new flag --rego-enable-parsed-events which enables parsed events.

benchmark                                                              iter         time/iter    bytes alloc             allocs
---------                                                              ----         ---------    -----------             ------
BenchmarkEngineWithCodeInjectionSignature/rego-8                        100    12760.62 μs/op   5807573 B/op   123602 allocs/op
BenchmarkEngineWithCodeInjectionSignature/rego_+_prepared_events-8      100     8942.85 μs/op   6026101 B/op   112120 allocs/op
BenchmarkEngineWithCodeInjectionSignature/golang-8                      100      991.93 μs/op    441537 B/op     3004 allocs/op
BenchmarkEngineWithCodeInjectionSignature/golang_+_prepared_events-8    100      986.84 μs/op    445371 B/op     3011 allocs/op
BenchmarkEngineWithCodeInjectionSignature/wasm-8                        100    34173.33 μs/op   6380418 B/op   116519 allocs/op
BenchmarkEngineWithCodeInjectionSignature/wasm_+_prepared_events-8      100    32303.88 μs/op   6374508 B/op   116451 allocs/op

Signed-off-by: Simar simar@linux.com

@simar7 simar7 marked this pull request as ready for review September 3, 2021 00:11
@simar7 simar7 self-assigned this Sep 3, 2021
danielpacak
danielpacak suggested changes Sep 3, 2021
View reviewed changes
tracee-rules/engine/engine.go Outdated Show resolved Hide resolved
tracee-rules/engine/engine.go Outdated Show resolved Hide resolved
tracee-rules/main.go Outdated Show resolved Hide resolved
@simar7
feat: Add flag for prepared events
0080fdb 
Signed-off-by: Simar <simar@linux.com>
@simar7
fix: Change engine.NewEngine() prototype to accommodate new flag
ce30e5a 
Signed-off-by: Simar <simar@linux.com>
@simar7
fix: Remove unnecessary casts for sending to dispatchEvent()
cd8d51e 
Signed-off-by: Simar <simar@linux.com>
@simar7
fix: Prefix "rego" for enable-parsed-events flag
7b1146e 
Signed-off-by: Simar <simar@linux.com>
@simar7
fix: Update tests
b9f3714 
Signed-off-by: Simar <simar@linux.com>
danielpacak
danielpacak suggested changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@danielpacak danielpacak left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment before we merge this one 🚀

tracee-rules/engine/engine.go Outdated Show resolved Hide resolved
@simar7
fix: Simplify the function prototype for dispatchEvent
168329c 
Signed-off-by: Simar <simar@linux.com>
@simar7 simar7 merged commit b475949 into aquasecurity:main Sep 7, 2021
@simar7 simar7 deleted the add-prepared-events branch September 7, 2021 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielpacak danielpacak danielpacak approved these changes

@itaysk itaysk Awaiting requested review from itaysk

Assignees

@simar7 simar7

Labels
area/rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@simar7 @danielpacak @grantseltzer