-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin): Add trivy-aws as a plugin #8
Conversation
Is it |
@knqyf263 Yes we had no other choice as the Trivy AWS subcommand already is |
I thought old Trivy users would keep using the built-in |
If an old Trivy user tries to install this plugin, Trivy picks up the subcommand over the plugin as that old version of Trivy will have the Another reason is that in this PR we will deprecate the So for those reasons, I chose the plugin to have a completely different name. Not ideal to name it that but I didn't have a better idea. We can still change it though to something else if you like or if you have a better idea. |
IIUC the implication is that the trivy aws plugin will only work from after we deprecate the built in target. if that's the worry i don't think it's that bad. also, if we really want to support this use case we can publish the plugin under another name, for the transition period. just my opinion |
Yes, it makes sense. However,
If that is a technical constraint, it could be achieved by looking at whether the
If you decide that using a different name is better in terms of user experience, I'm fine with that. |
As @itaysk said, if we have a transition period where users can use both the built-in aws and the plugin, we definitely need another name. But according to aquasecurity/trivy#6819, we'll drop |
I don't think it's bad as |
Actually I also thought the same but maybe took an overly cautious approach 😄 - I agree since it is experimental we can remove it immediately in next release and as a result have a clean |
To be merged after aquasecurity/trivy-aws#153 gets merged.