add app nil check (#5274)

aquasecurity · Oct 1, 2023 · 1840584 · 1840584
1 parent c5ae9f2
commit 1840584
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 0 deletions.
diff --git a/pkg/fanal/analyzer/language/dotnet/nuget/nuget.go b/pkg/fanal/analyzer/language/dotnet/nuget/nuget.go
@@ -71,6 +71,11 @@ func (a *nugetLibraryAnalyzer) PostAnalyze(_ context.Context, input analyzer.Pos
 			return xerrors.Errorf("NuGet parse error: %w", err)
 		}
 
+		// nuget file doesn't contain dependencies
+		if app == nil {
+			return nil
+		}
+
 		for i, lib := range app.Libraries {
 			license, ok := foundLicenses[lib.ID]
 			if !ok {

diff --git a/pkg/fanal/analyzer/language/dotnet/nuget/nuget_test.go b/pkg/fanal/analyzer/language/dotnet/nuget/nuget_test.go
@@ -166,6 +166,22 @@ func Test_nugetibraryAnalyzer_Analyze(t *testing.T) {
 				},
 			},
 		},
+		{
+			name: "happy path lock file without dependencies.",
+			dir:  "testdata/lock-without-deps",
+			env: map[string]string{
+				"HOME": "testdata/repository",
+			},
+			want: &analyzer.AnalysisResult{},
+		},
+		{
+			name: "sad path",
+			dir:  "testdata/sad",
+			env: map[string]string{
+				"HOME": "testdata/repository",
+			},
+			want: &analyzer.AnalysisResult{},
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {

diff --git a/pkg/fanal/analyzer/language/dotnet/nuget/testdata/lock-without-deps/packages.lock.json b/pkg/fanal/analyzer/language/dotnet/nuget/testdata/lock-without-deps/packages.lock.json
@@ -0,0 +1,6 @@
+{
+  "version": 1,
+  "dependencies": {
+    "net6.0": {}
+  }
+}