Skip to content

Commit

Permalink
Change log format (#30)
Browse files Browse the repository at this point in the history
  • Loading branch information
masahiro331 authored and knqyf263 committed May 19, 2019
1 parent fa72bef commit f82ff5a
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 6 deletions.
2 changes: 1 addition & 1 deletion cmd/trivy/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ OPTIONS:
err := app.Run(os.Args)
if err != nil {
if log.Logger != nil {
log.Logger.Fatal(err)
log.Fatal(err)
}
l.Fatal(err)
}
Expand Down
17 changes: 14 additions & 3 deletions pkg/log/logger.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,13 @@ import (
"golang.org/x/xerrors"
)

var Logger *zap.SugaredLogger
var (
Logger *zap.SugaredLogger
debugOption bool
)

func InitLogger(debug bool) (err error) {
debugOption = debug
Logger, err = newLogger(debug)
if err != nil {
return xerrors.Errorf("error in new logger: %w", err)
Expand All @@ -29,8 +33,8 @@ func newLogger(debug bool) (*zap.SugaredLogger, error) {
Level: level,
Encoding: "console",
Development: debug,
DisableStacktrace: !debug,
DisableCaller: !debug,
DisableStacktrace: true,
DisableCaller: true,
EncoderConfig: zapcore.EncoderConfig{
TimeKey: "Time",
LevelKey: "Level",
Expand All @@ -53,3 +57,10 @@ func newLogger(debug bool) (*zap.SugaredLogger, error) {

return logger.Sugar(), nil
}

func Fatal(err error) {
if debugOption {
Logger.Fatalf("%+v", err)
}
Logger.Fatal(err)
}
4 changes: 2 additions & 2 deletions pkg/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ func Run(c *cli.Context) (err error) {
autoRefresh := c.Bool("auto-refresh")
skipUpdate := c.Bool("skip-update")
if (refresh || autoRefresh) && skipUpdate {
log.Logger.Fatal("The --skip-update option can not be specified with the --refresh or --auto-refresh option")
return xerrors.New("The --skip-update option can not be specified with the --refresh or --auto-refresh option")
}

if err = db.Init(); err != nil {
Expand All @@ -84,7 +84,7 @@ func Run(c *cli.Context) (err error) {
dbVersion := db.GetVersion()
if dbVersion != "" && dbVersion != cliVersion {
if !autoRefresh {
log.Logger.Fatal("Detected version update of trivy. Please try again with --refresh or --auto-refresh option")
return xerrors.New("Detected version update of trivy. Please try again with --refresh or --auto-refresh option")
}
needRefresh = true
}
Expand Down

0 comments on commit f82ff5a

Please sign in to comment.