Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws)!: Remove aws subcommand #6995

Merged
merged 3 commits into from
Jun 25, 2024
Merged

feat(aws)!: Remove aws subcommand #6995

merged 3 commits into from
Jun 25, 2024

Conversation

simar7
Copy link
Member

@simar7 simar7 commented Jun 22, 2024

Description

See discussion: #6818

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263
Copy link
Collaborator

Are you going to just remove the subcommand? Don't we show a hint to existing users somehow? (e.g. aquasecurity/trivy-plugin-index#8 (comment))

@simar7 simar7 changed the title BREAKING(aws): Remove aws subcommand feat(aws)!: Remove aws subcommand Jun 25, 2024
@simar7 simar7 marked this pull request as ready for review June 25, 2024 05:08
@simar7 simar7 requested a review from knqyf263 as a code owner June 25, 2024 05:08
@simar7
Copy link
Member Author

simar7 commented Jun 25, 2024

Are you going to just remove the subcommand? Don't we show a hint to existing users somehow? (e.g. aquasecurity/trivy-plugin-index#8 (comment))

Added!

@simar7 simar7 added this pull request to the merge queue Jun 25, 2024
Merged via the queue into main with commit 979e118 Jun 25, 2024
13 checks passed
@simar7 simar7 deleted the remove-aws-cmd branch June 25, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants