Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misconf): fix infer type for null value #7424

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Aug 30, 2024

Description

An example of a CloudFormation template for which parsing fails:

AWSTemplateFormatVersion: 2010-09-09
Parameters:
  Email:
    Type: String
Conditions:
  SubscribeEmail: !Not [!Equals [ !Ref Email, ""]]

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
@nikpivkin nikpivkin marked this pull request as ready for review August 30, 2024 14:32
@nikpivkin nikpivkin requested a review from simar7 as a code owner August 30, 2024 14:32
@simar7 simar7 added this pull request to the merge queue Aug 31, 2024
Merged via the queue into aquasecurity:main with commit 0cac3ac Aug 31, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants