Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(image): add --server option for remote scans #1871

Merged
merged 13 commits into from May 15, 2022
Merged

feat(image): add --server option for remote scans #1871

merged 13 commits into from May 15, 2022

Conversation

afdesk
Copy link
Contributor

@afdesk afdesk commented Mar 23, 2022 •
edited

Description

Added a new option --server to image command for scans in client/server mode.

client command is deprecated now.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@afdesk afdesk marked this pull request as ready for review March 23, 2022 08:51
@afdesk afdesk requested a review from knqyf263 March 23, 2022 08:51
@knqyf263 knqyf263 added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 5, 2022
@afdesk
Copy link
Contributor Author

afdesk commented Apr 6, 2022

merged main branch here

knqyf263
knqyf263 reviewed Apr 26, 2022
View reviewed changes
Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! In addition, we should add new flags to image and add "DEPRECATED" to client.
https://github.com/aquasecurity/trivy/tree/main/docs/docs/references/cli

afdesk
afdesk commented May 13, 2022
View reviewed changes
go.sum Outdated
Comment on lines 199 to 200
github.com/aquasecurity/trivy-kubernetes v0.0.1-alpha.2 h1:iF21H/OkbFZKdJFyqw5rliWHK3v4P6antB67j2Fihgs=
github.com/aquasecurity/trivy-kubernetes v0.0.1-alpha.2/go.mod h1:9fU3sHz/wXN5ruZ5snUEJpzm2X6pUndKucv1mz9Walc=
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run go mod tidy.
these deps remove for main branch too

@afdesk afdesk requested a review from knqyf263 May 13, 2022 14:56
@knqyf263 knqyf263 added this to the v0.28.0 milestone May 15, 2022
@knqyf263 knqyf263 merged commit 96a5cb1 into main May 15, 2022
@knqyf263 knqyf263 deleted the image_server branch May 15, 2022 11:56
liamg pushed a commit that referenced this pull request Jun 7, 2022
@afdesk @knqyf263
feat(image): add --server option for remote scans (#1871)
6045dfe 
Co-authored-by: knqyf263 <knqyf263@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees

@afdesk afdesk

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
v0.28.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@afdesk @knqyf263